Rename outstandingRequests to availableQueueSpace #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outstandingRequests was actually representing the available space in the RxJava queue. This renames it to better match reality. Also changed to only make the request if there is available queue space. We now decrement availableQueueSpace ahead of determine whether to request another item.
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Aug 21, 2018
Ordered the release notes in ascending order of their issue # Added release notes for awslabs#374 and awslabs#375
sahilpalvia
pushed a commit
that referenced
this pull request
Aug 21, 2018
* Update release notes for release 2.0.1 * Updated version to 2.0.1 * Added notes for PR #371, and cleaned up formatting * Reordered release notes, and added additional fixes Ordered the release notes in ascending order of their issue # Added release notes for #374 and #375 * Add release notes to the change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outstandingRequests was actually representing the available space in
the RxJava queue. This renames it to better match reality.
Also changed to only make the request if there is available queue
space. We now decrement availableQueueSpace ahead of determine
whether to request another item.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.